Conversation
|
Claude finished @mbevc1's task in 2m 27s —— View job PR Review: feat: improve version checking
Static AnalysisAll checks pass: SummaryThis is a solid, well-structured PR. The changes address real pain points (JSON output pollution in CI, version check on What's good:
Minor nits (non-blocking):
No bugs, no security issues, no missing edge cases. The previous review rounds have been thorough and the feedback has been addressed well. LGTM. |
mbevc1
left a comment
There was a problem hiding this comment.
Goroutine-safety nit on SetCheckForUpdateOverride — inline with a sync.RWMutex suggestion and a race test. Current call site is fine by happens-before; the mutex is cheap insurance against future callers / flaky timings.
Generated by Claude Code
mbevc1
left a comment
There was a problem hiding this comment.
Coverage gap: executeCommandC bypasses innerMain, so the new --version sync-notice branch in main.go has no test coverage. Inline with a sketch calling innerMain directly via the existing SetCheckForUpdateOverride helper.
Generated by Claude Code
Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com>
future prof machine formatting Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com>
update the comment as well Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com>
Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com>
Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com>
d37685b to
8ff25e7
Compare
* feat: improve version checking * Update internal/version/update_check.go Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com> * feat: improve version checking - fix tests * feat: improve version checking - review improvements * feat: improve version checking - fix testing * feat: improve version checking - add version test * feat: improve version checking - fix version test * chore: Update internal/version/update_check.go * feat: improve version checking - fix missing import * chore: Update cmd/kosli/root.go future prof machine formatting Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com> * chore: Update cmd/kosli/root.go update the comment as well Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com> * feat: improve version checking - add race test * fix: AI broken suggestion * feat: improve version checking - improve fragile testing * feat: improve version checking - remove duplicated and add empty version test * feat: improve version checking - disable when in debug mode * fix: Update cmd/kosli/version.go typo Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com> * chore: Update cmd/kosli/root.go comment Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com> * feat: improve version checking - parse DEBUG ENV same as Viper --------- Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com>
--versiondevas version